Skip to content

Fix NF trying to run when old version of nextflow#345

Merged
apeltzer merged 6 commits intonf-core:devfrom
jfy133:wrong_nf_ver_fix
Feb 6, 2020
Merged

Fix NF trying to run when old version of nextflow#345
apeltzer merged 6 commits intonf-core:devfrom
jfy133:wrong_nf_ver_fix

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Feb 5, 2020

Now stops with understandable error

Adresses: #344

Thanks @hughcross for originally 'discovering this' and @pditommaso for pointing us towards the correct fix.

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • CHANGELOG.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@jfy133 jfy133 requested a review from apeltzer February 5, 2020 08:14
@jfy133 jfy133 self-assigned this Feb 5, 2020
@jfy133 jfy133 requested a review from maxibor February 5, 2020 08:14
@drpatelh
Copy link
Copy Markdown
Member

drpatelh commented Feb 5, 2020

Hi @jfy133 . This is something we should probably include in the template too. In fact, the linting is failing because it isnt:
https://github.com/nf-core/tools/blob/9e33e7f02758964a1a09436af1eb6afe0e596e4c/nf_core/lint.py#L467

Not entirely sure there is a proper way around this 🤔 until it's added in the next release. You could lint with the dev version of tools like @maxulysse but that isn't ideal.

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Feb 5, 2020

Hi @jfy133 . This is something we should probably include in the template too. In fact, the linting is failing because it isnt:
https://github.com/nf-core/tools/blob/9e33e7f02758964a1a09436af1eb6afe0e596e4c/nf_core/lint.py#L467

Not entirely sure there is a proper way around this until it's added in the next release. You could lint with the dev version of tools like @maxulysse but that isn't ideal.

Ha, I just asked in slack about this. I could instead take the approach suggest to me on gitter which is to make my 'own' check in the condition...

@maxulysse
Copy link
Copy Markdown
Member

Comment thread main.nf Outdated
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
Copy link
Copy Markdown
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jfy133 !

@apeltzer apeltzer merged commit da407f8 into nf-core:dev Feb 6, 2020
@jfy133 jfy133 deleted the wrong_nf_ver_fix branch February 10, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants