Skip to content

Fix NF trying to run when old version of nextflow #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apeltzer merged 6 commits into from
Feb 6, 2020
Merged

Fix NF trying to run when old version of nextflow #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09a045b
Merge pull request #33 from nf-core/dev
jfy133 Feb 5, 2020
3e3425a
Try ! prefix to stop NF if wrong version
jfy133 Feb 5, 2020
c9d01d1
Update CHANGELOG.md
jfy133 Feb 5, 2020
5b2b107
Replace with internal check
jfy133 Feb 5, 2020
531ce95
! not allowed by nf-core linting currently :(
jfy133 Feb 5, 2020
a51cb06
Update main.nf
jfy133 Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
* [#327](https://github.com/nf-core/eager/pull/327) - Speed up strip_input_fastq process and make it more robust
* [#342](https://github.com/nf-core/eager/pull/342) - Updated to match nf-core tools 1.8 linting guidelines
* [#339](https://github.com/nf-core/eager/issues/339) - Converted unnecessary zcat + gzip to just cat for a performance boost
* [#344](https://github.com/nf-core/eager/issues/344) - Fixed pipeline still trying to run when using old nextflow version

### `Dependencies`

Expand Down
7 changes: 7 additions & 0 deletions main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,13 @@ where_are_my_files = file("$baseDir/assets/where_are_my_files.txt")
* SANITY CHECKING
*/

// NF version check! Will replace with manifest system once allowed by nf-core/tools

if( !nextflow.version.matches('>=19.10.0') ) {
println "This workflow requires Nextflow version 19.10.0 or greater -- You are running version $nextflow.version"
exit 1
}

// Validate inputs
if ( params.fasta.isEmpty () ){
exit 1, "Please specify --fasta with the path to your reference"
Expand Down
⚡