Conversation
Closed
…pped reads and endogenous DNA pre-post filter
jfy133
approved these changes
Jul 29, 2020
Member
|
@apeltzer and I got the However the remaining tests don't work properly (see my notes) |
Minor fixes
jfy133
approved these changes
Aug 3, 2020
Member
jfy133
left a comment
There was a problem hiding this comment.
LGTM now. This includes a lot of minor fixes as well as AWS. But should be good once our final AWS pass goes (dreamy_venter). Then MERGE @apelter (finally!).
Up to you if you want to run the small test profiles too on AWS first...
| #### `--bwa_index` | ||
|
|
||
| If you want to use pre-existing `bwa index` indices, please supply the path **and file** to the FASTA you also specified in `--fasta` (see above). EAGER2 will automagically detect the index files by searching for the FASTA filename with the corresponding `bwa` index file suffixes. | ||
| If you want to use pre-existing `bwa index` indices, please supply the **directory** to the FASTA you also specified in `--fasta` (see above). EAGER2 will automagically detect the index files by searching for the FASTA filename with the corresponding `bwa` index file suffixes. |
Member
There was a problem hiding this comment.
Suggested change
| If you want to use pre-existing `bwa index` indices, please supply the **directory** to the FASTA you also specified in `--fasta` (see above). EAGER2 will automagically detect the index files by searching for the FASTA filename with the corresponding `bwa` index file suffixes. | |
| If you want to use pre-existing `bwa index` indices, please supply the **directory** to the FASTA you also specified in `--fasta` (see above). nf-core/eager will automagically detect the index files by searching for the FASTA filename with the corresponding `bwa` index file suffixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our handling of indices wasn't properly done I fear, so this is an attempt to get that fixed :-)
PR checklist
nextflow run . -profile test,docker --paired_end).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updated