-
Notifications
You must be signed in to change notification settings - Fork 88
Adjusted fixes for AWS index handling #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 41 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
5dec901
Adjusted fixes for AWS index handling
apeltzer a19e32b
Fix supplied indices and typo
apeltzer 6b6d9ca
Fix test
apeltzer 65048fc
Zipped fasta it is
apeltzer 8be5066
Fix some more indices
apeltzer fd43ba8
Fix path
apeltzer dea0244
Fix strip_input
apeltzer ee4721f
Fix some more paths
apeltzer 96fff7a
Fix small malt issue
apeltzer 95ccd01
Merge branch 'dev' into fix-aws
apeltzer e1a5782
Atttempt to fix last tmissing bits for index handlign
apeltzer 3a9d847
Merge branch 'fix-aws' of https://github.com/nf-core/eager into fix-aws
apeltzer e09082c
Some more fixes
apeltzer 1e5c8a4
Prefix with def to fix
apeltzer fbb5309
Make new dummy file replace Class() with instanceof and remove dummy NAs
jfy133 c20eb50
One more
jfy133 d13a078
Stop file collisions
jfy133 1e4035b
Remove debugging code
jfy133 1096321
Remove last code TODO after local testing
jfy133 bbb210f
Merge branch 'fix-aws' into aws-syncing
jfy133 f109a80
Merge pull request #514 from nf-core/aws-syncing
jfy133 fe4e8a3
Make bwa input as path
jfy133 a477b0d
Remove duplicate strip_fastq process
jfy133 ae33488
Fix inaccesible BAMs due to grouping of single elements when skipping…
jfy133 0330c6b
Remove debugging stuff
jfy133 827d585
Add some more dumps
apeltzer cd2ecb5
Add benchmark_vikingfish_single
apeltzer bc59f45
Replace jfy133 with nf-core
apeltzer 2477526
Dummy file added
apeltzer 47993ef
Try ensuring all read inputs into mapping are single elements
jfy133 139b357
Merge branch 'fix-aws' of github.com:nf-core/eager into fix-aws
jfy133 a474e6b
Fix broken tag for MarkDuplicates
jfy133 82a15f6
Clean markdupped BAM name for MultiQC and hide occasional qualimap co…
jfy133 f6393fa
Fix circularmapper and remove some leftover dumps
jfy133 8a0bce0
Tweaked general stats (and output.md) to make more logical flow of ma…
jfy133 08d45e8
Start fixing no-preseq when markdup
jfy133 bb1465b
Fixed and documented preseq not running when using markdups
jfy133 baaa430
Fix GATK UG always publishing BAIs even if not requested
jfy133 e8635bc
Fix occasional pre BAMtrimming library_merge failure
jfy133 59d710f
Fix PMD param in validations
jfy133 a43f4a4
Merge remote-tracking branch 'upstream/dev' into fix-aws
apeltzer 2fe4c53
Fix ci
apeltzer 5c49e6f
Fix supplying fasta Index
apeltzer 424651e
Fix CI
apeltzer 6ebd4b6
Remove failed arrayfy hack
jfy133 f2cf2a5
Merge branch 'fix-aws' of github.com:nf-core/eager into fix-aws
jfy133 1d7d53e
Fix bad R2 when not existing in lanemerge
jfy133 1d66da7
Fix downstream poop-gen tools NO_FILE
jfy133 5a9cb6c
Fix strip merged FASTQ
jfy133 0b39ce6
Fix pileupcaller
jfy133 48783d9
Merge branch 'fix-aws' into minor-fixes
jfy133 d648742
Merge pull request #534 from nf-core/minor-fixes
jfy133 8225a8c
Clarify name when non-tsv and fix missing skipme merging after lane …
jfy133 247f43e
Remove leftover view and run strip_Fastq test on more appropriate tSV
jfy133 c0fe4dc
Send NucContam JSON to MQC
jfy133 e2a8b84
Fix linting
jfy133 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| This is a dummy file for when we need a 'fake' file to satisfy all nextflow channel inputs being filled, even if we actually only use one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| This is a second dummy file for when we need a 'fake' file to satisfy all nextflow channel inputs being filled, even if we actually only use one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * ------------------------------------------------- | ||
| * Nextflow config file for running tests | ||
| * ------------------------------------------------- | ||
| * Defines bundled input files and everything required | ||
| * to run a fast and simple test. Use as follows: | ||
| * nextflow run nf-core/eager -profile test, docker (or singularity, or conda) | ||
| */ | ||
|
|
||
| params { | ||
| config_profile_name = 'nf-core/eager benchmarking - Viking Fish profile' | ||
| config_profile_description = "A 'fullsized' benchmarking profile for deepish sequencing aDNA data" | ||
|
|
||
| //Input data | ||
| input = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/testdata/Benchmarking/benchmarking_vikingfish_single.tsv' | ||
| // Genome reference | ||
| fasta = 'https://ftp.ncbi.nlm.nih.gov/genomes/refseq/vertebrate_other/Gadus_morhua/representative/GCF_902167405.1_gadMor3.0/GCF_902167405.1_gadMor3.0_genomic.fna.gz' | ||
|
|
||
| bwaalnn = 0.04 | ||
| bwaalnl = 1024 | ||
|
|
||
| run_bam_filtering = true | ||
| bam_discard_unmapped = true | ||
| bam_unmapped_type = 'discard' | ||
| bam_mapping_quality_threshold = 25 | ||
|
|
||
| run_genotyping = true | ||
| genotyping_tool = 'hc' | ||
| genotyping_source = 'raw' | ||
| gatk_ploidy = 2 | ||
|
|
||
| } | ||
|
|
||
| process { | ||
| withName:'adapter_removal'{ | ||
| cpus = { check_max( 8, 'cpus' ) } | ||
| memory = { check_max( 16.GB * task.attempt, 'memory' ) } | ||
| time = { check_max( 2.h * task.attempt, 'time' ) } | ||
| } | ||
| withName:'bwa'{ | ||
| cpus = { check_max( 8, 'cpus' ) } | ||
| memory = { check_max( 16.GB * task.attempt, 'memory' ) } | ||
| time = { check_max( 8.h * task.attempt, 'time' ) } | ||
| } | ||
| withName:'dedup'{ | ||
| cpus = { check_max( 8, 'cpus' ) } | ||
| memory = { check_max( 16.GB * task.attempt, 'memory' ) } | ||
| time = { check_max( 4.h * task.attempt, 'time' ) } | ||
| } | ||
| withName:'genotyping_hc'{ | ||
| cpus = { check_max( 8, 'cpus' ) } | ||
| memory = { check_max( 16.GB * task.attempt, 'memory' ) } | ||
| time = { check_max( 8.h * task.attempt, 'time' ) } | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.