Skip to content
Merged
Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
5dec901
Adjusted fixes for AWS index handling
apeltzer Jul 12, 2020
a19e32b
Fix supplied indices and typo
apeltzer Jul 12, 2020
6b6d9ca
Fix test
apeltzer Jul 12, 2020
65048fc
Zipped fasta it is
apeltzer Jul 12, 2020
8be5066
Fix some more indices
apeltzer Jul 12, 2020
fd43ba8
Fix path
apeltzer Jul 12, 2020
dea0244
Fix strip_input
apeltzer Jul 12, 2020
ee4721f
Fix some more paths
apeltzer Jul 12, 2020
96fff7a
Fix small malt issue
apeltzer Jul 13, 2020
95ccd01
Merge branch 'dev' into fix-aws
apeltzer Jul 13, 2020
e1a5782
Atttempt to fix last tmissing bits for index handlign
apeltzer Jul 13, 2020
3a9d847
Merge branch 'fix-aws' of https://github.com/nf-core/eager into fix-aws
apeltzer Jul 13, 2020
e09082c
Some more fixes
apeltzer Jul 13, 2020
1e5c8a4
Prefix with def to fix
apeltzer Jul 13, 2020
fbb5309
Make new dummy file replace Class() with instanceof and remove dummy NAs
jfy133 Jul 14, 2020
c20eb50
One more
jfy133 Jul 14, 2020
d13a078
Stop file collisions
jfy133 Jul 14, 2020
1e4035b
Remove debugging code
jfy133 Jul 14, 2020
1096321
Remove last code TODO after local testing
jfy133 Jul 14, 2020
bbb210f
Merge branch 'fix-aws' into aws-syncing
jfy133 Jul 16, 2020
f109a80
Merge pull request #514 from nf-core/aws-syncing
jfy133 Jul 16, 2020
fe4e8a3
Make bwa input as path
jfy133 Jul 16, 2020
a477b0d
Remove duplicate strip_fastq process
jfy133 Jul 16, 2020
ae33488
Fix inaccesible BAMs due to grouping of single elements when skipping…
jfy133 Jul 16, 2020
0330c6b
Remove debugging stuff
jfy133 Jul 16, 2020
827d585
Add some more dumps
apeltzer Jul 16, 2020
cd2ecb5
Add benchmark_vikingfish_single
apeltzer Jul 16, 2020
bc59f45
Replace jfy133 with nf-core
apeltzer Jul 16, 2020
2477526
Dummy file added
apeltzer Jul 16, 2020
47993ef
Try ensuring all read inputs into mapping are single elements
jfy133 Jul 21, 2020
139b357
Merge branch 'fix-aws' of github.com:nf-core/eager into fix-aws
jfy133 Jul 21, 2020
a474e6b
Fix broken tag for MarkDuplicates
jfy133 Jul 27, 2020
82a15f6
Clean markdupped BAM name for MultiQC and hide occasional qualimap co…
jfy133 Jul 27, 2020
f6393fa
Fix circularmapper and remove some leftover dumps
jfy133 Jul 27, 2020
8a0bce0
Tweaked general stats (and output.md) to make more logical flow of ma…
jfy133 Jul 27, 2020
08d45e8
Start fixing no-preseq when markdup
jfy133 Jul 28, 2020
bb1465b
Fixed and documented preseq not running when using markdups
jfy133 Jul 28, 2020
baaa430
Fix GATK UG always publishing BAIs even if not requested
jfy133 Jul 28, 2020
e8635bc
Fix occasional pre BAMtrimming library_merge failure
jfy133 Jul 28, 2020
59d710f
Fix PMD param in validations
jfy133 Jul 28, 2020
a43f4a4
Merge remote-tracking branch 'upstream/dev' into fix-aws
apeltzer Jul 28, 2020
2fe4c53
Fix ci
apeltzer Jul 28, 2020
5c49e6f
Fix supplying fasta Index
apeltzer Jul 28, 2020
424651e
Fix CI
apeltzer Jul 28, 2020
6ebd4b6
Remove failed arrayfy hack
jfy133 Jul 28, 2020
f2cf2a5
Merge branch 'fix-aws' of github.com:nf-core/eager into fix-aws
jfy133 Jul 28, 2020
1d7d53e
Fix bad R2 when not existing in lanemerge
jfy133 Jul 28, 2020
1d66da7
Fix downstream poop-gen tools NO_FILE
jfy133 Jul 29, 2020
5a9cb6c
Fix strip merged FASTQ
jfy133 Jul 29, 2020
0b39ce6
Fix pileupcaller
jfy133 Jul 29, 2020
48783d9
Merge branch 'fix-aws' into minor-fixes
jfy133 Aug 3, 2020
d648742
Merge pull request #534 from nf-core/minor-fixes
jfy133 Aug 3, 2020
8225a8c
Clarify name when non-tsv and fix missing skipme merging after lane …
jfy133 Aug 3, 2020
247f43e
Remove leftover view and run strip_Fastq test on more appropriate tSV
jfy133 Aug 3, 2020
c0fe4dc
Send NucContam JSON to MQC
jfy133 Aug 3, 2020
e2a8b84
Fix linting
jfy133 Aug 3, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
nextflow run ${GITHUB_WORKSPACE} -profile test_tsv,docker --save_reference
- name: REFERENCE Basic workflow, with supplied indices
run: |
nextflow run ${GITHUB_WORKSPACE} -profile test_tsv,docker --bwa_index 'results/reference_genome/bwa_index/BWAIndex/Mammoth_MT_Krause.fasta' --fasta_index 'https://github.com/nf-core/test-datasets/blob/eager/reference/Mammoth/Mammoth_MT_Krause.fasta.fai'
nextflow run ${GITHUB_WORKSPACE} -profile test_tsv,docker --bwa_index 'results/reference_genome/bwa_index/BWAIndex/' --fasta_index 'https://github.com/nf-core/test-datasets/blob/eager/reference/Mammoth/Mammoth_MT_Krause.fasta.fai'
- name: REFERENCE Run the basic pipeline with FastA reference with `fna` extension
run: |
nextflow run ${GITHUB_WORKSPACE} -profile test_tsv_fna,docker
Expand Down
1 change: 0 additions & 1 deletion assets/dummy.txt

This file was deleted.

1 change: 1 addition & 0 deletions assets/nf-core_eager_dummy.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This is a dummy file for when we need a 'fake' file to satisfy all nextflow channel inputs being filled, even if we actually only use one.
1 change: 1 addition & 0 deletions assets/nf-core_eager_dummy2.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This is a second dummy file for when we need a 'fake' file to satisfy all nextflow channel inputs being filled, even if we actually only use one.
2 changes: 1 addition & 1 deletion conf/benchmarking_vikingfish.config
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ params {
config_profile_description = "A 'fullsized' benchmarking profile for deepish sequencing aDNA data"

//Input data
input = 'https://raw.githubusercontent.com/jfy133/test-datasets/eager/testdata/Benchmarking/benchmarking_vikingfish.tsv'
input = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/testdata/Benchmarking/benchmarking_vikingfish.tsv'
// Genome reference
fasta = 'https://ftp.ncbi.nlm.nih.gov/genomes/refseq/vertebrate_other/Gadus_morhua/representative/GCF_902167405.1_gadMor3.0/GCF_902167405.1_gadMor3.0_genomic.fna.gz'

Expand Down
56 changes: 56 additions & 0 deletions conf/benchmarking_vikingfish_single.config
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/*
* -------------------------------------------------
* Nextflow config file for running tests
* -------------------------------------------------
* Defines bundled input files and everything required
* to run a fast and simple test. Use as follows:
* nextflow run nf-core/eager -profile test, docker (or singularity, or conda)
*/

params {
config_profile_name = 'nf-core/eager benchmarking - Viking Fish profile'
config_profile_description = "A 'fullsized' benchmarking profile for deepish sequencing aDNA data"

//Input data
input = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/testdata/Benchmarking/benchmarking_vikingfish_single.tsv'
// Genome reference
fasta = 'https://ftp.ncbi.nlm.nih.gov/genomes/refseq/vertebrate_other/Gadus_morhua/representative/GCF_902167405.1_gadMor3.0/GCF_902167405.1_gadMor3.0_genomic.fna.gz'

bwaalnn = 0.04
bwaalnl = 1024

run_bam_filtering = true
bam_discard_unmapped = true
bam_unmapped_type = 'discard'
bam_mapping_quality_threshold = 25

run_genotyping = true
genotyping_tool = 'hc'
genotyping_source = 'raw'
gatk_ploidy = 2

}

process {
withName:'adapter_removal'{
cpus = { check_max( 8, 'cpus' ) }
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
time = { check_max( 2.h * task.attempt, 'time' ) }
}
withName:'bwa'{
cpus = { check_max( 8, 'cpus' ) }
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
time = { check_max( 8.h * task.attempt, 'time' ) }
}
withName:'dedup'{
cpus = { check_max( 8, 'cpus' ) }
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
time = { check_max( 4.h * task.attempt, 'time' ) }
}
withName:'genotyping_hc'{
cpus = { check_max( 8, 'cpus' ) }
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
time = { check_max( 8.h * task.attempt, 'time' ) }
}

}
4 changes: 2 additions & 2 deletions docs/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ Use this if you do not have pre-made reference FASTA indices for `bwa`, `samtool

#### `--bwa_index`

If you want to use pre-existing `bwa index` indices, please supply the path **and file** to the FASTA you also specified in `--fasta` (see above). EAGER2 will automagically detect the index files by searching for the FASTA filename with the corresponding `bwa` index file suffixes.
If you want to use pre-existing `bwa index` indices, please supply the **directory** to the FASTA you also specified in `--fasta` (see above). EAGER2 will automagically detect the index files by searching for the FASTA filename with the corresponding `bwa` index file suffixes.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you want to use pre-existing `bwa index` indices, please supply the **directory** to the FASTA you also specified in `--fasta` (see above). EAGER2 will automagically detect the index files by searching for the FASTA filename with the corresponding `bwa` index file suffixes.
If you want to use pre-existing `bwa index` indices, please supply the **directory** to the FASTA you also specified in `--fasta` (see above). nf-core/eager will automagically detect the index files by searching for the FASTA filename with the corresponding `bwa` index file suffixes.


For example:

Expand All @@ -371,7 +371,7 @@ nextflow run nf-core/eager \
-profile test,docker \
--input '*{R1,R2}*.fq.gz'
--fasta 'results/reference_genome/bwa_index/BWAIndex/Mammoth_MT_Krause.fasta' \
--bwa_index 'results/reference_genome/bwa_index/BWAIndex/Mammoth_MT_Krause.fasta'
--bwa_index 'results/reference_genome/bwa_index/BWAIndex/'
```

> `bwa index` does not give you an option to supply alternative suffixes/names for these indices. Thus, the file names generated by this command _must not_ be changed, otherwise EAGER2 will not be able to find them.
Expand Down
Loading