Conversation
Get AWS last minute fixes
Important! Template update for nf-core/tools v1.11
Added link to 1240k bedfile. Typo.
fix aws full test profiles
Master to dev
Bump runtimes for human stresstesting
Final chance...
…ingletons retained
Adapterremoval prefix fix
Version bump for patch release
Merging template updates
ewels
requested changes
Dec 7, 2020
Member
ewels
left a comment
ewels
left a comment
There was a problem hiding this comment.
The metro map is so cool! 🤩
Generally looks good, except the big one that all parameter documentation should be stripped from usage.md.
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
ewels
approved these changes
Dec 8, 2020
Member
ewels
left a comment
ewels
left a comment
There was a problem hiding this comment.
Ace! Couple of super tiny niggles but otherwise good to go.
As discussed on Slack, could be nice to move the very long --help text back to usage.md (sorry 👀 ) but that's an optional extra. See atacseq dev for an example of where this has been done in another pipeline: https://nf-co.re/atacseq/dev/usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core/eager pull request
This PR is for release of the 2.2.2 patch.
This most important includes:
PR checklist
nextflow run . -profile test,docker --paired_end).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md