Skip to content

fix aws full test profiles#600

Merged
apeltzer merged 2 commits intonf-core:devfrom
ggabernet:dev
Nov 2, 2020
Merged

fix aws full test profiles#600
apeltzer merged 2 commits intonf-core:devfrom
ggabernet:dev

Conversation

@ggabernet
Copy link
Copy Markdown
Member

nf-core/eager pull request

Fixes the AWS full tests profile import in nextflow.config.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker --paired_end).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@ggabernet ggabernet requested review from apeltzer and jfy133 November 1, 2020 14:56
@ggabernet
Copy link
Copy Markdown
Member Author

Is there a reason why you use the awsfulltest config instead of the test_full config for the AWS full size test workflow?

It is quite standardized that the rest of the pipelines just use the test_full profile for the AWS full tests, so it would be neat to keep it like this in all pipelines, unless there is a specific reason for it, of course 😄

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Nov 1, 2020

Mmm I don't think there is a particular reason. It is probably a legacy thing from very early on when aws testing was being set up and not yet standardised, right @apeltzer ? (#hipsters). Probably fine to follow the mainstream now.

@apeltzer
Copy link
Copy Markdown
Member

apeltzer commented Nov 1, 2020

Yes I think that's the reason 🙈

@ggabernet
Copy link
Copy Markdown
Member Author

right, you were pioneers with the full dataset testing in AWS! I've removed it then in exchange for the test_full profile. This should hopefully fix the AWS full tests, and with the new workflow dispatch option, they can be triggered manually under the GitHub Actions tab (select the AWS full test workflow) to test if they pass in the dev branch. Once you trigger them, the tests can be followed with Tower and the nf-core-awstests@mailinator.com email address to actually know if the pipeline runs through 🤞

@apeltzer apeltzer merged commit 8b41ab8 into nf-core:dev Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants