Skip to content

Add PU tag to Read Groups for all mapping methods#658

Merged
jfy133 merged 9 commits intonf-core:devfrom
IdoBar:patch-2
Jan 14, 2021
Merged

Add PU tag to Read Groups for all mapping methods#658
jfy133 merged 9 commits intonf-core:devfrom
IdoBar:patch-2

Conversation

@IdoBar
Copy link
Copy Markdown
Contributor

@IdoBar IdoBar commented Jan 11, 2021

Add PU tag to Read Groups for all mapping methods.
This is an improvement to PR #656

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

Hi @IdoBar,

It looks like this pull-request is has been made against the IdoBar/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the IdoBar/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@IdoBar IdoBar changed the base branch from master to dev January 11, 2021 17:15
@jfy133 jfy133 mentioned this pull request Jan 12, 2021
11 tasks
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Jan 12, 2021

Looks good to me! I've just made a pull request into your new patch again, so you have the correct CHANGELOG file to update. Let me know if you need help updating the changelog.

Get the latest dev version to have correct CHANGELOG
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Jan 13, 2021

Ok, now you have the CHANGELOG for the next release,

please edit the CHANGELOG file, and under 2.3.1dev [unreleased] and fixed, add something like

#655 - Updated read groups for all mappers to allow proper GATK validation

(or w/e).

Finally, please add your name and github handle to the README under 'additional contributors' :).

Note all links above point to your patch branch of your fork, so you can edit those directly!

Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IdoBar

@jfy133 jfy133 merged commit 7c0938d into nf-core:dev Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants