Fix schema accidently strings values to correct integers#659
Merged
apeltzer merged 1 commit intonf-core:devfrom Jan 13, 2021
Merged
Fix schema accidently strings values to correct integers#659apeltzer merged 1 commit intonf-core:devfrom
apeltzer merged 1 commit intonf-core:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to close #654 . It makes sures all integers defaults are actually integer values and not accidently in strings. It also adds an a enum for
bt2nas acoording to bowtie2 docs can only be either 0 or 1.This should hopefully fix launch GUI params.json issues during internal eager parameter validation
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).