Skip to content

Fix schema accidently strings values to correct integers#659

Merged
apeltzer merged 1 commit intonf-core:devfrom
jfy133:schema-number-type-fix
Jan 13, 2021
Merged

Fix schema accidently strings values to correct integers#659
apeltzer merged 1 commit intonf-core:devfrom
jfy133:schema-number-type-fix

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Jan 13, 2021

This is to close #654 . It makes sures all integers defaults are actually integer values and not accidently in strings. It also adds an a enum for bt2n as acoording to bowtie2 docs can only be either 0 or 1.

This should hopefully fix launch GUI params.json issues during internal eager parameter validation

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

@apeltzer apeltzer merged commit 8ad2456 into nf-core:dev Jan 13, 2021
@jfy133 jfy133 deleted the schema-number-type-fix branch January 14, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants