Skip to content

Fix file staging for print_nuclear_contamination#667

Merged
TCLamnidis merged 7 commits intonf-core:devfrom
IdoBar:patch-3
Jan 27, 2021
Merged

Fix file staging for print_nuclear_contamination#667
TCLamnidis merged 7 commits intonf-core:devfrom
IdoBar:patch-3

Conversation

@IdoBar
Copy link
Copy Markdown
Contributor

@IdoBar IdoBar commented Jan 19, 2021

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

jfy133 and others added 2 commits January 14, 2021 14:18
Replace `val` with `path` to correct staging of input files
@github-actions
Copy link
Copy Markdown

Hi @IdoBar,

It looks like this pull-request is has been made against the IdoBar/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the IdoBar/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@IdoBar IdoBar changed the base branch from master to dev January 19, 2021 11:01
Comment thread CHANGELOG.md Outdated
Correct line spacing in markdown
@jfy133 jfy133 linked an issue Jan 25, 2021 that may be closed by this pull request
5 tasks
Comment thread main.nf Outdated
Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
@TCLamnidis TCLamnidis merged commit 01cf3e9 into nf-core:dev Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print nuclear contamination fails (input files not staged)

4 participants