added pcne module#11307
Conversation
|
Please join the nf-core organization on GitHub to enable the CI-tests to run on your PR. You can request to join the organization via #github-invitations in the nf-core slack. You can join the nf-core slack via https://nf-co.re/join. |
Thank you! Done! |
|
@nf-core-bot fix linting |
famosab
left a comment
There was a problem hiding this comment.
Thank you for your contribution to nf-core! We really appreciate it. I added a few comments to your PR.
Co-authored-by: Famke Bäuerle <45968370+famosab@users.noreply.github.com>
Corrected indentation for description field in meta.yml.
formatted to pass prettier check
famosab
left a comment
There was a problem hiding this comment.
We are almost done, you still should change the way the snapshots are being generated (see comment) and I would suggest to have a test that shows that the plot file is being produced (and how that happens - via an args?). Otherwise very good work!
There was a problem hiding this comment.
@mashehu This snapshot fails linting because it says versions are not present but that is not the case? Maybe the linting is too restrictive here as well?
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda