Skip to content

added pcne module#11307

Open
riccabolla wants to merge 36 commits intonf-core:masterfrom
riccabolla:new-module-pcne
Open

added pcne module#11307
riccabolla wants to merge 36 commits intonf-core:masterfrom
riccabolla:new-module-pcne

Conversation

@riccabolla
Copy link
Copy Markdown

@riccabolla riccabolla commented Apr 25, 2026

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@riccabolla riccabolla marked this pull request as draft April 25, 2026 15:31
@famosab
Copy link
Copy Markdown
Contributor

famosab commented Apr 27, 2026

Please join the nf-core organization on GitHub to enable the CI-tests to run on your PR. You can request to join the organization via #github-invitations in the nf-core slack. You can join the nf-core slack via https://nf-co.re/join.

@riccabolla
Copy link
Copy Markdown
Author

Please join the nf-core organization on GitHub to enable the CI-tests to run on your PR. You can request to join the organization via #github-invitations in the nf-core slack. You can join the nf-core slack via https://nf-co.re/join.

Thank you! Done!

@riccabolla riccabolla self-assigned this Apr 27, 2026
@famosab
Copy link
Copy Markdown
Contributor

famosab commented Apr 27, 2026

@nf-core-bot fix linting

Copy link
Copy Markdown
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to nf-core! We really appreciate it. I added a few comments to your PR.

Comment thread modules/nf-core/pcne/tests/main.nf.test Outdated
Comment thread modules/nf-core/pcne/tests/main.nf.test Outdated
Comment thread modules/nf-core/pcne/main.nf Outdated
Comment thread modules/nf-core/pcne/main.nf
Comment thread modules/nf-core/pcne/main.nf
Comment thread modules/nf-core/pcne/meta.yml
Comment thread modules/nf-core/pcne/main.nf Outdated
Comment thread modules/nf-core/pcne/tests/main.nf.test Outdated
Comment thread modules/nf-core/pcne/tests/main.nf.test.snap Outdated
@riccabolla riccabolla marked this pull request as ready for review May 4, 2026 15:51
@riccabolla riccabolla requested a review from famosab May 4, 2026 15:51
Copy link
Copy Markdown
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost done, you still should change the way the snapshots are being generated (see comment) and I would suggest to have a test that shows that the plot file is being produced (and how that happens - via an args?). Otherwise very good work!

Comment thread modules/nf-core/pcne/tests/main.nf.test Outdated
Comment thread modules/nf-core/pcne/tests/main.nf.test Outdated
Comment thread modules/nf-core/pcne/main.nf
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mashehu This snapshot fails linting because it says versions are not present but that is not the case? Maybe the linting is too restrictive here as well?

Comment thread modules/nf-core/pcne/tests/main.nf.test
@riccabolla riccabolla requested a review from famosab May 8, 2026 16:02
@riccabolla riccabolla added the new module Adding a new module label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new module Adding a new module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants