Skip to content

feat: update dragmap to follow new bwa/mem + bwamem2/mem logic#1146

Merged
maxulysse merged 1 commit intonf-core:masterfrom
maxulysse:master_dragmap
Dec 8, 2021
Merged

feat: update dragmap to follow new bwa/mem + bwamem2/mem logic#1146
maxulysse merged 1 commit intonf-core:masterfrom
maxulysse:master_dragmap

Conversation

@maxulysse
Copy link
Copy Markdown
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@maxulysse
Copy link
Copy Markdown
Member Author

cf nf-core/sarek#464

Copy link
Copy Markdown
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxulysse maxulysse merged commit ca3ae9f into nf-core:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants