Skip to content

fix: match expected input for bwa/mem (no fai) using map. updated tes…#11549

Merged
piplus2 merged 2 commits intonf-core:masterfrom
piplus2:fix-fastq-align-bamcmp-bwa
May 7, 2026
Merged

fix: match expected input for bwa/mem (no fai) using map. updated tes…#11549
piplus2 merged 2 commits intonf-core:masterfrom
piplus2:fix-fastq-align-bamcmp-bwa

Conversation

@piplus2
Copy link
Copy Markdown
Contributor

@piplus2 piplus2 commented May 7, 2026

PR checklist

Closes #11548

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

The test now passes the expected arguments for BWA_INDEX (no fai).
For the workflow, the expected input is passed to BWA_MEM using .map. To do so, the test must pass a channel.value as expected by the workflow.
Also the snapshots are updated to reconcile with the new test.

@piplus2 piplus2 self-assigned this May 7, 2026
//

BWA_MEM_PRIMARY(ch_reads, ch_primary_index, ch_fasta_fai, true)
ch_fasta = ch_fasta_fai.map { it -> tuple(it[0], it[1]) }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ch_fasta = ch_fasta_fai.map { it -> tuple(it[0], it[1]) }
ch_fasta = ch_fasta_fai.map { file -> tuple(file[0], file[1]) }

just to make it clearer that we are not using the old syntax 🙂

@piplus2 piplus2 added this pull request to the merge queue May 7, 2026
Merged via the queue into nf-core:master with commit 1fb16b0 May 7, 2026
16 checks passed
@piplus2 piplus2 deleted the fix-fastq-align-bamcmp-bwa branch May 7, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FASTQ_ALIGN_BAMCMP_BWA fails CI because of wrong input in the test

2 participants