Skip to content

fix the collision between input and output filename for single read#11575

Open
piplus2 wants to merge 3 commits intonf-core:masterfrom
piplus2:fix-collision-deacon-input-output-naming-single-read
Open

fix the collision between input and output filename for single read#11575
piplus2 wants to merge 3 commits intonf-core:masterfrom
piplus2:fix-collision-deacon-input-output-naming-single-read

Conversation

@piplus2
Copy link
Copy Markdown
Contributor

@piplus2 piplus2 commented May 8, 2026

PR checklist

Closes #11302

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Now when single read input is passed to the process, the output filename gets a _filtered suffix so that there's no collision with the input filename.
No changes for paired reads.
Also now the test for single read checks that some seqs are actually filtered.

@piplus2 piplus2 self-assigned this May 8, 2026
@piplus2 piplus2 requested review from pmoris and vagkaratzas May 8, 2026 15:35
Copy link
Copy Markdown
Contributor

@vagkaratzas vagkaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just override the ext.prefix on the pipeline's module.args instead.

@piplus2
Copy link
Copy Markdown
Contributor Author

piplus2 commented May 8, 2026

Yes, but that means the user is already aware of the collision. At the moment, there's no feedback so there's a chance of a silent bug.

@piplus2
Copy link
Copy Markdown
Contributor Author

piplus2 commented May 8, 2026

@piplus2 piplus2 requested a review from vagkaratzas May 8, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEACON_FILTER module errors if single fastq given has name collision with prefix

2 participants