fix the collision between input and output filename for single read#11575
Open
piplus2 wants to merge 3 commits intonf-core:masterfrom
Open
fix the collision between input and output filename for single read#11575piplus2 wants to merge 3 commits intonf-core:masterfrom
piplus2 wants to merge 3 commits intonf-core:masterfrom
Conversation
… update test and snapshot
vagkaratzas
reviewed
May 8, 2026
Contributor
vagkaratzas
left a comment
There was a problem hiding this comment.
You can just override the ext.prefix on the pipeline's module.args instead.
Contributor
Author
|
Yes, but that means the user is already aware of the collision. At the moment, there's no feedback so there's a chance of a silent bug. |
Contributor
Author
|
I've included the error message following https://nf-co.re/docs/specifications/components/modules/naming-conventions#command-file-output-naming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #11302
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile condaNow when single read input is passed to the process, the output filename gets a
_filteredsuffix so that there's no collision with the input filename.No changes for paired reads.
Also now the test for single read checks that some seqs are actually filtered.