Adjusted CNVKIT/BATCH for germline mode#1719
Merged
SusiJo merged 4 commits intonf-core:masterfrom Jun 2, 2022
Merged
Conversation
11 tasks
| // somatic_mode cram_input | ||
| if (tumor_cram && normal_cram){ | ||
| """ | ||
| samtools view -T $fasta $fai_reference $tumor -@ $task.cpus -o $tumor_out |
Contributor
There was a problem hiding this comment.
you don't need the funky ##idx## thing?
Contributor
Author
There was a problem hiding this comment.
not if the fasta_fai is passed along with the fasta reference genome and both files are stored locally
Contributor
There was a problem hiding this comment.
ok I'll ask about this on slack
Contributor
Author
There was a problem hiding this comment.
if both files are not local and are accessed instead via an https://, s3:// or other URL then the "##idx##" would be needed.
FriederikeHanssen
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
This PR enables the
cnvkit/batchmodule to run ingermline modein addition totumor_onlyandsomatic mode.versions.ymlfile.labelPROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-awarePROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-awarePROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware