Skip to content

Adjusted CNVKIT/BATCH for germline mode#1719

Merged
SusiJo merged 4 commits intonf-core:masterfrom
SusiJo:cnvkit_bam
Jun 2, 2022
Merged

Adjusted CNVKIT/BATCH for germline mode#1719
SusiJo merged 4 commits intonf-core:masterfrom
SusiJo:cnvkit_bam

Conversation

@SusiJo
Copy link
Copy Markdown
Contributor

@SusiJo SusiJo commented Jun 1, 2022

PR checklist

This PR enables the cnvkit/batch module to run in germline mode in addition to tumor_only and somatic mode.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@SusiJo SusiJo mentioned this pull request Jun 1, 2022
11 tasks
@SusiJo SusiJo requested a review from FriederikeHanssen June 1, 2022 16:11
// somatic_mode cram_input
if (tumor_cram && normal_cram){
"""
samtools view -T $fasta $fai_reference $tumor -@ $task.cpus -o $tumor_out
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the funky ##idx## thing?

Copy link
Copy Markdown
Contributor Author

@SusiJo SusiJo Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not if the fasta_fai is passed along with the fasta reference genome and both files are stored locally

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll ask about this on slack

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if both files are not local and are accessed instead via an https://, s3:// or other URL then the "##idx##" would be needed.

@SusiJo SusiJo merged commit 1c33eeb into nf-core:master Jun 2, 2022
@SusiJo SusiJo deleted the cnvkit_bam branch October 17, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants