Skip to content

SVDB MERGE samtools version#1913

Merged
WackerO merged 8 commits intonf-core:masterfrom
WackerO:svdb
Jul 20, 2022
Merged

SVDB MERGE samtools version#1913
WackerO merged 8 commits intonf-core:masterfrom
WackerO:svdb

Conversation

@WackerO
Copy link
Copy Markdown
Contributor

@WackerO WackerO commented Jul 20, 2022

Small PR to add the samtools version to SVDB MERGE, follow-up to #1910

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@WackerO WackerO merged commit 6b011dd into nf-core:master Jul 20, 2022
@WackerO WackerO deleted the svdb branch July 20, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants