Skip to content

Remove docker.runOptions in favor of docker.userEmulation#525

Merged
drpatelh merged 1 commit intonf-core:masterfrom
heuermh:docker-userEmulation
May 27, 2021
Merged

Remove docker.runOptions in favor of docker.userEmulation#525
drpatelh merged 1 commit intonf-core:masterfrom
heuermh:docker-userEmulation

Conversation

@heuermh
Copy link
Copy Markdown
Contributor

@heuermh heuermh commented May 27, 2021

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@heuermh heuermh mentioned this pull request May 27, 2021
14 tasks
@pontus
Copy link
Copy Markdown
Contributor

pontus commented May 27, 2021

See also nf-core/sarek#378.

@heuermh heuermh mentioned this pull request May 27, 2021
14 tasks
@drpatelh
Copy link
Copy Markdown
Member

Great!

@drpatelh drpatelh merged commit 68c678d into nf-core:master May 27, 2021
@heuermh heuermh deleted the docker-userEmulation branch May 27, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants