Skip to content

Getting dev up to date#208

Merged
maxulysse merged 52 commits intonf-core:devfrom
maxulysse:dev
May 26, 2020
Merged

Getting dev up to date#208
maxulysse merged 52 commits intonf-core:devfrom
maxulysse:dev

Conversation

@maxulysse
Copy link
Copy Markdown
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team May 24, 2020 12:02
@maxulysse maxulysse added this to the 3.0 milestone May 24, 2020
Copy link
Copy Markdown
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread main.nf
@maxulysse maxulysse merged commit 25dd584 into nf-core:dev May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants