feat: add flake-parts installer image options#1223
Open
different-name wants to merge 1 commit intonix-community:masterfrom
Open
feat: add flake-parts installer image options#1223different-name wants to merge 1 commit intonix-community:masterfrom
different-name wants to merge 1 commit intonix-community:masterfrom
Conversation
42c513a to
be79162
Compare
Contributor
Author
|
Marking this as ready for review, since the install script is implemented & I'm happy with the way it's configured |
be79162 to
e065bac
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/offline-automated-installation-images-for-disko/75953/1 |
Member
|
How about some tests? |
Contributor
Author
|
Tests is on the todo above, I don't have much experience with CI, and wanted to gauge if this is something desirable before continuing with docs & tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an offline installer configuration is already demonstrated in the disko docs, however it's pretty dense and I think a module would be a great replacement for copying that large chunk of code from the docs
This PR adds the
disko-installoption set to the flake-parts module, which generates installer images with dependencies & install script includedMinimal config:
Exhaustive config:
TODO
This works to generate installer images (I have tested with
iso-installer) with ainstall-nixos-unattendedscript, however it still needs work:listOf str