doc: describe ready-for-release state#844
Merged
mhdawson merged 2 commits intonodejs:masterfrom Jun 5, 2020
sam-github:doc-ready-for-release
Merged
doc: describe ready-for-release state#844mhdawson merged 2 commits intonodejs:masterfrom sam-github:doc-ready-for-release
mhdawson merged 2 commits intonodejs:masterfrom
sam-github:doc-ready-for-release
Conversation
Its indicated by assignment to a group.
Trott
reviewed
Apr 3, 2020
| responsible for following it through to resolution and disclosure. | ||
| - Once a fix is ready for release, the issue should be assigned to the group | ||
| `Ready for release`, and a comment added indicating the relevant PRs that | ||
| need to be merged during the release process. |
Member
There was a problem hiding this comment.
It's not clear to me what "assigned to the group Ready for release" means. Is there maybe a missing word or something?
Contributor
Author
There was a problem hiding this comment.
https://github.com/nodejs/TSC/pull/844/files#r403256247, sorry, I'd previously used the work "Team" not "Group", clearer now? @Trott ?
Member
There was a problem hiding this comment.
If that's a HackerOne team, then yes.
Contributor
Author
There was a problem hiding this comment.
Perhaps the team could simply be called Releasers?
sam-github
commented
Apr 3, 2020
jasnell
approved these changes
Apr 28, 2020
Co-authored-by: Sam Roberts <vieuxtech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its indicated by assignment to a group.