Skip to content

doc: describe ready-for-release state #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhdawson merged 2 commits into from
Jun 5, 2020
Merged

doc: describe ready-for-release state #844

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4e32e3
doc: describe ready-for-release state
sam-github Apr 1, 2020
1ce6488
Update Security-Team.md
mhdawson Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Security-Team.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ The expected workflow for issues reported to Node.js is:
getting resolved. Comments on the issue when someone is working on it are
useful, as is assignment of the issue to a person who agrees to be
responsible for following it through to resolution and disclosure.
- Once a fix is ready for release, the issue should be assigned to the group
`Ready for release`, and a comment added indicating the relevant PRs that
Comment thread
mhdawson marked this conversation as resolved.
Outdated
need to be merged during the release process.
Copy link
Copy Markdown
Member

@Trott Trott Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me what "assigned to the group Ready for release" means. Is there maybe a missing word or something?

Copy link
Copy Markdown
Contributor Author

@sam-github sam-github Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nodejs/TSC/pull/844/files#r403256247, sorry, I'd previously used the work "Team" not "Group", clearer now? @Trott ?

Copy link
Copy Markdown
Member

@Trott Trott Apr 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's a HackerOne team, then yes.

Copy link
Copy Markdown
Contributor Author

@sam-github sam-github Apr 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the team could simply be called Releasers?

5. `RESOLVED`: State for an issue that has had a fix published. Issues in this
state should be disclosed.
6. ...: Final states for issues that we will not fix:
Expand Down
⚡