fix(fetch): allow custom implementation of AbortSignal#1608
Merged
ronag merged 1 commit intonodejs:mainfrom Aug 18, 2022
Merged
fix(fetch): allow custom implementation of AbortSignal#1608ronag merged 1 commit intonodejs:mainfrom
ronag merged 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
- Coverage 94.90% 94.88% -0.03%
==========================================
Files 50 50
Lines 4753 4752 -1
==========================================
- Hits 4511 4509 -2
- Misses 242 243 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This wasn't the correct solution; it makes us fall out of line with the spec. Instead, when parsing an AbortSignal, a Line 282 in e46d8bf Of course the webidl interface converter could also be improved such that when passing a |
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR closes #1605.
A test case is added to ensure it is the
DOMExceptionbeing thrown, notTypeError.cc @mcollina @KhafraDev