fix: allow third party AbortControllers#1609
Merged
mcollina merged 2 commits intonodejs:mainfrom Aug 19, 2022
Merged
Conversation
ronag
approved these changes
Aug 18, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fix: allow third party AbortControllers * fix: lint Co-authored-by: Matthew Aitken <matthew@Matthews-MacBook-Air.local>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: allow third party AbortControllers * fix: lint Co-authored-by: Matthew Aitken <matthew@Matthews-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complements #1608 (totally fixes #1605)
When better checks are performed in the
interfaceConverterfunction, this partial revert will be more useful. From my comment in #1608:Of course the webidl interface converter could also be improved such that when passing a strict: false option, it would check the object's Symbol.toStringTag/constructor name [instead of allowing any value].