Use embedded-hal 1.0 in tests and examples#436
Conversation
qwandor
force-pushed
the
embedded-hal-examples
branch
from
a35a228 to
2677ab1
Compare
qwandor
force-pushed
the
embedded-hal-examples
branch
from
2677ab1 to
93ee789
Compare
There was a problem hiding this comment.
Can you comment on the change here?
The change from:
use embedded_hal::blocking::spi::Write;
to:
use embedded_hal::spi::SpiBus;
There was a problem hiding this comment.
The SPI traits changed significantly in embedded-hal 1.0. You can read more about it in the embedded-hal documentation, but one difference is that there is now a single trait for a bus or a device, rather than separate traits for read vs. write vs. transfer.
There was a problem hiding this comment.
Can you please comment on the change of the use of timer and PWM?
There was a problem hiding this comment.
What about it? embedded-hal 1.0 no longer includes traits for timers, so we have intrinsic methods instead. The names of some of the PWM methods have changed.
There was a problem hiding this comment.
line 46: Can you please comment on the change to make pulldown_pin mutuable?
There was a problem hiding this comment.
embedded_hal::digital::InputPin::is_low takes &mut self, so it needs to be mutable for the call on line 49.
There was a problem hiding this comment.
line 53-54: Can you please comment on the change made from:
(state.input_pin.as_ref().unwrap().is_low().unwrap());
to:
(state.input_pin.as_mut().unwrap().is_low().unwrap());
There was a problem hiding this comment.
Again, embedded_hal::digital::InputPin::is_low takes &mut self, so we need a mutable reference.
adamhott
left a comment
adamhott
left a comment
There was a problem hiding this comment.
Responses to comments are reasonable as are code changes. Tested on micro:bit V2, ran into some limitations with certain examples being built for other nrf hals for other chips. Overall, looks great! Approved!
2 participants
No description provided.