-
Notifications
You must be signed in to change notification settings - Fork 149
Use embedded-hal 1.0 in tests and examples #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please comment on the change of the use of timer and PWM?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment on the change here?
The change from:
use embedded_hal::blocking::spi::Write;
to:
use embedded_hal::spi::SpiBus;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SPI traits changed significantly in
embedded-hal1.0. You can read more about it in theembedded-haldocumentation, but one difference is that there is now a single trait for a bus or a device, rather than separate traits for read vs. write vs. transfer.