Skip to content

In @nx/eslint, --fix should respect --quiet #31401

@bkp-ttd

Description

@bkp-ttd

Current Behavior

When using eslint directly, eslint --fix --quiet will only fix issues that aren't silenced by --quiet. However nx run lint --quiet --fix has the opposite behavior - it will attempt to autofix all lint issues, even ones that would normally be ignored by --quiet.

In other words, nx run lint --quiet --fix behaves the same as nx run lint --fix.

I think it's an easy fix - pull request incoming...

Expected Behavior

nx run lint --quiet --fix should only fix issues that aren't silenced by --quiet

GitHub Repo

No response

Steps to Reproduce

  1. Write some code that produces fixable lint warnings (not errors)
  2. Verify that those warnings are silenced by --quiet and appear without --quiet
  3. Run nx run lint --quiet --fix and observe that the warnings are fixed

Nx Report

NX   Report complete - copy this into the issue template

Node           : 20.12.0
OS             : darwin-arm64
Native Target  : aarch64-macos
npm            : 10.5.0

nx              : 20.0.7
@nx/js          : 20.0.7
@nx/jest        : 20.0.7
@nx/eslint      : 20.0.7
@nx/workspace   : 20.0.7
@nx/devkit      : 20.0.7
@nx/esbuild     : 20.0.7
@nx/playwright  : 20.0.7
@nx/vite        : 20.0.7
@nx/web         : 20.0.7
@nx/webpack     : 20.0.7
typescript      : 5.8.3
---------------------------------------
Community plugins:
@nxify-io/graphql-codegen : 0.0.2

Failure Logs

N/A

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

I think it's an easy fix - pull request incoming...

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions