Skip to content

fix(linter): respect the --quiet option when running with --fix#31403

Merged
leosvelperez merged 1 commit intonrwl:masterfrom
bkp-ttd:fix-respects-quiet
Jun 18, 2025
Merged

fix(linter): respect the --quiet option when running with --fix#31403
leosvelperez merged 1 commit intonrwl:masterfrom
bkp-ttd:fix-respects-quiet

Conversation

@bkp-ttd
Copy link
Copy Markdown
Contributor

@bkp-ttd bkp-ttd commented May 30, 2025

Current Behavior

nx run lint --quiet --fix doesn't respect --quiet and fixes all issues, even silenced ones. This is different from how eslint --quiet --fix behaves.

Expected Behavior

nx run lint --quiet --fix should only fix issues that aren't silenced by --quiet, like eslint does

Related Issue(s)

Fixes #31401

@bkp-ttd bkp-ttd requested review from a team, FrozenPandaz and vsavkin as code owners May 30, 2025 22:48
@bkp-ttd bkp-ttd requested a review from Coly010 May 30, 2025 22:48
@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 18, 2025 9:10am

@bkp-ttd bkp-ttd force-pushed the fix-respects-quiet branch from 7676a91 to 02e47fd Compare May 30, 2025 22:51
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 30, 2025

View your CI Pipeline Execution ↗ for commit 76e600d.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 28m 26s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 1m 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-18 09:32:28 UTC

@FrozenPandaz
Copy link
Copy Markdown
Contributor

Can you please fix your commit message so that it conforms to our guidelines in CONTRIBUTING.md?

@bkp-ttd bkp-ttd force-pushed the fix-respects-quiet branch from 02e47fd to 801c8f7 Compare June 3, 2025 17:37
@bkp-ttd
Copy link
Copy Markdown
Contributor Author

bkp-ttd commented Jun 3, 2025

Done, thanks for the ping

@leosvelperez
Copy link
Copy Markdown
Member

@bkp-ttd our current commit validator has an issue in the regex preventing the first character after fix(linter): to be -. Could you please rebase and change the commit message to something like fix(linter): respect --quiet when running with --fix?

@leosvelperez
Copy link
Copy Markdown
Member

@claude rebase this PR and update the commit message to "fix(linter): respect --quiet when running with --fix"

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jun 18, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

@leosvelperez leosvelperez changed the title fix(linter): --fix should respect --quiet fix(linter): respect the --quiet option when running with --fix Jun 18, 2025
@leosvelperez leosvelperez enabled auto-merge (squash) June 18, 2025 09:00
@leosvelperez leosvelperez merged commit 9406d2b into nrwl:master Jun 18, 2025
7 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In @nx/eslint, --fix should respect --quiet

3 participants