fix(js): do not infer the project type in the @nx/js/typescript plugin#32421
Merged
leosvelperez merged 1 commit intomasterfrom Aug 20, 2025
Merged
fix(js): do not infer the project type in the @nx/js/typescript plugin#32421leosvelperez merged 1 commit intomasterfrom
@nx/js/typescript plugin#32421leosvelperez merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 327d5fb
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Aug 20, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 22, 2025
…gin (#32421) ## Current Behavior The `@nx/js/typescript` plugin incorrectly infers that all projects are libraries. This is not correct, because apps also have tsconfig files which would be processed and targets will be inferred for them (e.g. `typecheck`). Depending on the order of the plugin execution, it can result in projects having the wrong type. ## Expected Behavior The `@nx/js/typescript` plugin should not infer the project type. The project type will be correctly derived later, when the project graph nodes are normalized. (cherry picked from commit 2788d91)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/js/typescriptplugin incorrectly infers that all projects are libraries. This is not correct, because apps also have tsconfig files which would be processed and targets will be inferred for them (e.g.typecheck). Depending on the order of the plugin execution, it can result in projects having the wrong type.Expected Behavior
The
@nx/js/typescriptplugin should not infer the project type. The project type will be correctly derived later, when the project graph nodes are normalized.