Skip to content

Repo dispatch#18

Merged
jburel merged 12 commits intoome:mainfrom
jburel:repo_dispatch
Oct 8, 2021
Merged

Repo dispatch#18
jburel merged 12 commits intoome:mainfrom
jburel:repo_dispatch

Conversation

@jburel
Copy link
Copy Markdown
Member

@jburel jburel commented Sep 27, 2021

The proposed changes allow to trigger a job in this repository when a PR is merged in one of the "upstream" repositories that the test_suite covers e.g. ome-zarr-py
It uses the repository dispatch event.

  • An event run_test_suite is posted by the upstream repo when a PR is merged
  • This repository catches it and installs the code from the upstream PR
  • Run the corresponding tests from the ome_zarr_test_suite
  • Insert a comment on the PR with link to the ome_zarr_test_suite job indicacting success or failure so we can track with job was run
  • Create an issue with the bug label on the source repository if the job fails

@will-moore
Copy link
Copy Markdown
Member

I don't understand every line, but I get the gist of it. Looks good.

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Oct 6, 2021

Example of issue created ome/omero-ms-zarr#98. The issue was created even on success during the test

Copy link
Copy Markdown
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor, mostly style and comprehension comments. Otherwise, looks good.

Comment thread configure_test.py Outdated
Comment thread .github/workflows/main.yml
Comment thread scripts/bioformats2raw_fake Outdated
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Oct 7, 2021

@joshmoore I have re-used the name and review the explanation. It will be good to have that in place so we can evaluate it with the coming merge of ome-zarr-py PRs

@jburel jburel mentioned this pull request Oct 8, 2021
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Oct 8, 2021

Merging so we can test with the upcoming ome-zarr-py PRs

@jburel jburel merged commit bcd7e2c into ome:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants