Merged
Conversation
7d02e08 to
611b992
Compare
611b992 to
ba24f61
Compare
Member
|
I don't understand every line, but I get the gist of it. Looks good. |
Member
Author
|
Example of issue created ome/omero-ms-zarr#98. The issue was created even on success during the test |
joshmoore
reviewed
Oct 6, 2021
Member
joshmoore
left a comment
There was a problem hiding this comment.
Few minor, mostly style and comprehension comments. Otherwise, looks good.
Member
Author
|
@joshmoore I have re-used the name and review the explanation. It will be good to have that in place so we can evaluate it with the coming merge of ome-zarr-py PRs |
Open
Member
Author
|
Merging so we can test with the upcoming ome-zarr-py PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed changes allow to trigger a job in this repository when a PR is merged in one of the "upstream" repositories that the test_suite covers e.g. ome-zarr-py
It uses the repository dispatch event.
run_test_suiteis posted by the upstream repo when a PR is merged