Define modeling guidance for mismatches with standard env vars, add resource.attribute_list#106
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Aug 20, 2024
Conversation
…resource.attribute_list
trask
approved these changes
Jul 22, 2024
|
FYI - I'd like to go a different direction with resource variables BUT I think this makes good progress on status quo. See https://github.com/open-telemetry/oteps/pull/264/files - environment variable detector |
codeboten
approved these changes
Aug 19, 2024
brettmc
approved these changes
Aug 20, 2024
This was referenced Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves open-telemetry/opentelemetry-specification#3966.
OTEL_RESOURCE_ATTRIBUTESis string whose value is a comma separated list of key value pairs. This is not a natural way to represent key value pairs in YAML, yet for reasons discussed in PR#3966 is important for platforms. Therefore, we provide an alternative.resource.attributes_listproperty which matches the format ofOTEL_RESOURCE_ATTRIBUTES. Implementations merge the contents of.resource.attributesand.resource.attributes_list, with.resource.attributestaking priority.