Refactored ConsoleExporter#1590
Closed
utpilla wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@CodeBlanch It'd be great if you could take a look at this and let me know of what you think. This is in regards to this discussion: #1438 (comment) |
Contributor
Author
|
@cijothomas @reyang I would love to get any suggestions for this. |
Codecov Report
@@ Coverage Diff @@
## master #1590 +/- ##
==========================================
- Coverage 80.74% 80.64% -0.11%
==========================================
Files 242 244 +2
Lines 6544 6555 +11
==========================================
+ Hits 5284 5286 +2
- Misses 1260 1269 +9
|
Member
|
@utpilla I like it! I think this is definitely a more standard use of generics. Could probably clean it up even further like... public abstract class ConsoleExporter<T> : BaseExporter<T>
{
public override ExportResult Export(in Batch<T> batch)
{
foreach (var item in batch)
{
ExportItem(item);
}
}
protected abstract void ExportItem(T item);
protected void WriteLine(string message) { /* Existing code goes here*/ }
}
internal class ConsoleActivityExporter : ConsoleExporter<Activity>
{
protected override void ExportItem(Activity item)
{
WriteLine($"Activity.Id: {activity.Id}");
/* Etc. */
}
}Tweaks: Made ConsoleExporter abstract, switched the action to an abstract method, and made WriteLine protected so super can call it. |
Contributor
Author
|
I have created a new PR #1593 with the suggested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes