Refactor ConsoleExporter#1593
Merged
CodeBlanch merged 13 commits intoNov 25, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
==========================================
+ Coverage 80.56% 80.68% +0.11%
==========================================
Files 243 245 +2
Lines 6582 6575 -7
==========================================
+ Hits 5303 5305 +2
+ Misses 1279 1270 -9
|
cijothomas
approved these changes
Nov 20, 2020
cijothomas
left a comment
cijothomas
left a comment
Member
There was a problem hiding this comment.
LGTM. Please add this to changelog as there is public class changes.
CodeBlanch
reviewed
Nov 20, 2020
CodeBlanch
reviewed
Nov 20, 2020
CodeBlanch
reviewed
Nov 20, 2020
…/utpilla/opentelemetry-dotnet into utpilla/Refactor-ConsoleExporter
…/utpilla/opentelemetry-dotnet into utpilla/Refactor-ConsoleExporter
ejsmith
reviewed
Nov 24, 2020
utpilla
commented
Nov 24, 2020
cijothomas
approved these changes
Nov 25, 2020
Member
|
Okay to merge, with one more approval. |
CodeBlanch
approved these changes
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes