Skip to content

Use Trace.WriteLine instead of Debug.WriteLine for the Debug option#1719

Merged
cijothomas merged 2 commits into
open-telemetry:masterfrom
utpilla:utpilla/UpdateConsoleExporter
Jan 25, 2021
Merged

Use Trace.WriteLine instead of Debug.WriteLine for the Debug option#1719
cijothomas merged 2 commits into
open-telemetry:masterfrom
utpilla:utpilla/UpdateConsoleExporter

Conversation

@utpilla

@utpilla utpilla commented Jan 24, 2021

Copy link
Copy Markdown
Contributor

Fixes #1718

Changes

  • Replaced Debug.WriteLine with Trace.WriteLine in ConsoleExporter.cs

@utpilla utpilla requested a review from a team January 24, 2021 21:04
@codecov

codecov Bot commented Jan 24, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1719 (e225584) into master (02adc4c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1719   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files         250      250           
  Lines        6763     6764    +1     
=======================================
+ Hits         5558     5559    +1     
  Misses       1205     1205           
Impacted Files Coverage Δ
.../OpenTelemetry.Exporter.Console/ConsoleExporter.cs 37.50% <0.00%> (-5.36%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 94.28% <0.00%> (+1.42%) ⬆️

@CodeBlanch CodeBlanch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 06666cd into open-telemetry:master Jan 25, 2021
@utpilla utpilla deleted the utpilla/UpdateConsoleExporter branch January 27, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Trace.WriteLine instead of Debug.WriteLine in ConsoleExporter

4 participants