Skip to content

Use Trace.WriteLine instead of Debug.WriteLine for the Debug option #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 2 commits into from
Jan 25, 2021
Merged

Use Trace.WriteLine instead of Debug.WriteLine for the Debug option #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e225584
Use Trace.WriteLine instead of Debug.WriteLine for the Debug option
utpilla Jan 24, 2021
b36300e
Updated the CHANGELOG.md
utpilla Jan 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/OpenTelemetry.Exporter.Console/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
`ConsoleExporter` to get rid of type specific check in the class
([#1593](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1593))

* Replaced Debug.WriteLine with Trace.WriteLine to display the logs to the Debug
window with Release configuration
([#1719](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1719))

## 1.0.0-rc1.1

Released 2020-Nov-17
Expand Down
4 changes: 1 addition & 3 deletions src/OpenTelemetry.Exporter.Console/ConsoleExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
// limitations under the License.
// </copyright>

using System.Diagnostics;

namespace OpenTelemetry.Exporter
{
public abstract class ConsoleExporter<T> : BaseExporter<T>
Expand All @@ -37,7 +35,7 @@ protected void WriteLine(string message)

if (this.options.Targets.HasFlag(ConsoleExporterOutputTargets.Debug))
{
Debug.WriteLine(message);
System.Diagnostics.Trace.WriteLine(message);
}
}
}
Expand Down
⚡