Lock-free updates for HistogramSumCount

src/OpenTelemetry/CHANGELOG.md

@@ -2,9 +2,14 @@
 
 ## Unreleased
 
-* Make `IResourceDetector` public to allow custom implementations of resource detectors.
+* Make `IResourceDetector` public to allow custom implementations of resource
+  detectors.
   ([2897](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2897))
 
+* Perf improvement for HistogramSumCount updates, by implementing lock-free
+  updates.
+  ([2961](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2961))
+
 ## 1.2.0-rc2
 
 Released 2022-Feb-02

src/OpenTelemetry/Metrics/HistogramBuckets.cs

@@ -32,6 +32,8 @@ public class HistogramBuckets
 
         internal double SnapshotSum;
 
+        internal int IsCriticalSectionOccupied = 0;
+
         internal HistogramBuckets(double[] explicitBounds)
         {
             this.ExplicitBounds = explicitBounds;

src/OpenTelemetry/Metrics/MetricPoint.cs

@@ -335,10 +335,22 @@ internal void Update(double number)
 
                 case AggregationType.HistogramSumCount:
                     {
-                        lock (this.histogramBuckets.LockObject)
+                        var sw = default(SpinWait);
+                        while (true)
                         {
-                            this.runningValue.AsLong++;
-                            this.histogramBuckets.RunningSum += number;
+                            if (Interlocked.Exchange(ref this.histogramBuckets.IsCriticalSectionOccupied, 1) == 0)
+                            {
+                                unchecked
+                                {
+                                    this.runningValue.AsLong++;
+                                    this.histogramBuckets.RunningSum += number;
+                                }
+
+                                this.histogramBuckets.IsCriticalSectionOccupied = 0;
+                                break;
+                            }
+
+                            sw.SpinOnce();
                         }
 
                         break;