Skip to content

Add support for instrumentation scope attributes (Meter tags)#5089

Merged
utpilla merged 21 commits into
open-telemetry:mainfrom
cijothomas:cijothomas/metertags
Nov 29, 2023
Merged

Add support for instrumentation scope attributes (Meter tags)#5089
utpilla merged 21 commits into
open-telemetry:mainfrom
cijothomas:cijothomas/metertags

Conversation

@cijothomas

@cijothomas cijothomas commented Nov 28, 2023

Copy link
Copy Markdown
Member

Fixes #4563

Did not touch Prometheus exporters in this PR, better to wait till #5086 is merged.

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team November 28, 2023 18:16
@codecov

codecov Bot commented Nov 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5089 (3ac1cf5) into main (617ac6c) will decrease coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is 26.31%.

❗ Current head 3ac1cf5 differs from pull request most recent head c9e0eec. Consider uploading reports for the commit c9e0eec to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5089      +/-   ##
==========================================
- Coverage   83.36%   83.27%   -0.10%     
==========================================
  Files         296      296              
  Lines       12339    12355      +16     
==========================================
+ Hits        10287    10289       +2     
- Misses       2052     2066      +14     
Flag Coverage Δ
unittests 83.27% <26.31%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/Metric.cs 96.52% <100.00%> (+0.03%) ⬆️
src/OpenTelemetry/Metrics/MetricStreamIdentity.cs 86.66% <100.00%> (+0.30%) ⬆️
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <0.00%> (ø)
...tryProtocol/Implementation/MetricItemExtensions.cs 82.01% <20.00%> (-3.55%) ⬇️

... and 7 files with indirect coverage changes

Comment thread src/OpenTelemetry/Metrics/Metric.cs Outdated
Comment thread src/OpenTelemetry/Metrics/MetricStreamIdentity.cs Outdated
Comment thread test/OpenTelemetry.Tests/Metrics/MetricApiTestsBase.cs
Comment thread src/OpenTelemetry.Exporter.Console/ConsoleMetricExporter.cs Outdated
Comment thread src/OpenTelemetry.Exporter.Console/ConsoleMetricExporter.cs
Comment thread src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry/Metrics/Metric.cs
Comment thread test/OpenTelemetry.Tests/Metrics/MetricApiTestsBase.cs Outdated
Comment thread test/OpenTelemetry.Tests/Metrics/MetricApiTestsBase.cs
Comment thread test/OpenTelemetry.Tests/Metrics/MetricApiTestsBase.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export Instrumentation Scope attributes for a Meter (requires DiagnosticSource v8)

5 participants