Skip to content

Rafactor OtlpMetricExporter#5091

Merged
utpilla merged 1 commit into
open-telemetry:mainfrom
utpilla:utpilla/Rafactor-OtlpMetricExporter
Nov 29, 2023
Merged

Rafactor OtlpMetricExporter#5091
utpilla merged 1 commit into
open-telemetry:mainfrom
utpilla:utpilla/Rafactor-OtlpMetricExporter

Conversation

@utpilla

@utpilla utpilla commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Towards #5090
Follow-up to #5089

Changes

  • Refactoring of MetricItemExtensions.cs

@utpilla utpilla requested review from a team and alanwest November 29, 2023 01:51
@codecov

codecov Bot commented Nov 29, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5091 (60fb18c) into main (97442ef) will increase coverage by 0.07%.
The diff coverage is 74.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5091      +/-   ##
==========================================
+ Coverage   83.16%   83.24%   +0.07%     
==========================================
  Files         296      296              
  Lines       12351    12351              
==========================================
+ Hits        10272    10281       +9     
+ Misses       2079     2070       -9     
Flag Coverage Δ
unittests 83.24% <74.07%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tryProtocol/Implementation/MetricItemExtensions.cs 82.01% <74.07%> (ø)

... and 5 files with indirect coverage changes

@cijothomas cijothomas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utpilla utpilla merged commit 4e390e3 into open-telemetry:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants