Add instrumentation for aiohttp server

[ocelotl]

Add an instrumentation for aiohttp.

This implementation is a good reference.

[r4mbo7]

Hi !

I have tried the aiohttp_client integration in a sample project to get a client - server working using aiohttp. I ended up by not using aiohttp_client and manage spans manually.

It seems that aiohttp_client do not add any header in the aiohttp session to propagate the context across another service. I'm not familiar with Opentelemetry yet, I have certainly miss something and/or it is not an issue ?

Is there a specific guideline to add new instrumentation ?
Thanks.

[toumorokoshi]

Hi !

I have tried the aiohttp_client integration in a sample project to get a client - server working using aiohttp. I ended up by not using aiohttp_client and manage spans manually.

It seems that aiohttp_client do not add any header in the aiohttp session to propagate the context across another service. I'm not familiar with Opentelemetry yet, I have certainly miss something and/or it is not an issue ?

Is there a specific guideline to add new instrumentation ?
Thanks.

@r4mbo7 can you start a separate issue around that? This is a more general issue around adding instrumentation at all, bugfixes should be filed separately.

That said I believe #709 will fix your issue.

[martinell]

Why is the issue closed? How can I instrument an aiohttp server? Is there any documentation on this?

[toumorokoshi]

Why is the issue closed? How can I instrument an aiohttp server? Is there any documentation on this?

Hi! Sorry we didn't leave any links.

See https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/aiohttp_client/aiohttp_client.html for the aiohttp client. For the server, see https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/asgi/asgi.html for now (unfortunately we don't have a native server instrumentation, but we would love a contribution).

[tardyp]

Hi,

Still not sure why this has been closed. aiohttp-server is not really asgi compliant
aio-libs/aiohttp#2902

So it looks like there is a need for a native server

#709 is about client, not server, so it shouldn't have closed the issue.

[srikanthccv]

@tardyp This work is moved to contrib repo. Please take a look at open-telemetry/opentelemetry-python-contrib#508

[tardyp]

thank you so much for this info I couldn't find.not this PR will have better SEO :)