fix propagation of http headers#709
Merged
toumorokoshi merged 2 commits intoopen-telemetry:masterfrom May 27, 2020
Merged
Conversation
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks for catching that! if you can add a unit test happy to approve.
ecourreges-orange
changed the title
Contributor
Author
|
Note that I decided to add a basic test of the presence of the traceparent header in all requests emitted, rather than a new single test. |
add check presence of traceparent header in any aiohttp_client request
ocelotl
approved these changes
May 26, 2020
Member
|
thanks! |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #682
TODO: add unit test that proves it