feat: Added support for listing custom mountOptions#142
feat: Added support for listing custom mountOptions#142pentago wants to merge 1 commit intoopenebs-archive:developfrom pentago:develop
Conversation
Signed-off-by: pentago <purplertiza@gmail.com>
| isDefaultClass: false | ||
| backendStorageClass: "" | ||
| mountOptions: | ||
| - vers=4.1 |
There was a problem hiding this comment.
Keeping a provision for using mountOptions is ok, but I'd say enforcing a particular default like vers 4.1 won't be desired. A user deploying nfs server for a performant workload may prefer vers 3 for example, or some clients(like rhel) by default start negotiating highest supported vers i.e. 4.2.
There was a problem hiding this comment.
@pentago Please revert the changes done in values.yaml based on above comment.
There was a problem hiding this comment.
@dsharma-dc This doesn't seem to move forward. Would you be open to a separate PR for this? I've released a patch version on my fork and it works perfectly. 18e41e0
There was a problem hiding this comment.
@beschoenen I have created #164 to apply this change.
|
Closing this PR as the changes from this PR are picked up and applied under #164 |
4 participants
Signed-off-by: pentago purplertiza@gmail.com
Pull Request template
It fixes mounting of a provisioned NFS server pod in situations where the following issue occurs:
What this PR does?:
Enables user to add custom NFS mount options
Does this PR require any upgrade changes?:
No to my knowledge, maintainers please advise.
If the changes in this PR are manually verified, list down the scenarios covered::
Performed
helm templateto ensure proper output and tested deployment - worked fine.Any additional information for your reviewer? :
No.
Checklist:
<type>(<scope>): <subject>@pawanpraka1 here's the new PR as I wasn't able to fix the previous one by force-pushing with the signoff message, hopefully, it gets merged soon.