chore(chart): add nfs mount options field#164
Merged
dsharma-dc merged 2 commits intodevelopfrom Sep 19, 2023
Merged
Conversation
8 tasks
35b51bd to
7461ca6
Compare
Signed-off-by: pentago <purplertiza@gmail.com> Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
7461ca6 to
0e83011
Compare
niladrih
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request template
It fixes mounting of a provisioned NFS server pod in situations where the following issue occurs:
What this PR does?:
Enables user to add custom NFS mount options. Applies PR #142 essentially. Credits to author of #142.
Does this PR require any upgrade changes?:
No to my knowledge, maintainers please advise.
If the changes in this PR are manually verified, list down the scenarios covered::
Performed
helm templateto ensure proper output and tested deployment - worked fine.Any additional information for your reviewer? :
No.
Checklist:
<type>(<scope>): <subject>