Skip to content

chore(chart): add nfs mount options field#164

Merged
dsharma-dc merged 2 commits intodevelopfrom
mnt_opts
Sep 19, 2023
Merged

chore(chart): add nfs mount options field#164
dsharma-dc merged 2 commits intodevelopfrom
mnt_opts

Conversation

@dsharma-dc
Copy link
Copy Markdown
Contributor

Pull Request template

It fixes mounting of a provisioned NFS server pod in situations where the following issue occurs:

Warning  FailedMount  1s (x3 over 3s)  kubelet   MountVolume.SetUp failed for volume "pvc-79743abd-d5c9-4939-a48d-d3038aa30d2a" : mount failed: exit status 255
Mounting command: mount
Mounting arguments: -t nfs 10.0.244.196:/ /var/lib/kubelet/pods/14af0af3-da2e-4276-92e6-eb39d0d57341/volumes/kubernetes.io~nfs/pvc-79743abd-d5c9-4939-a48d-d3038aa30d2a
Output: mount: mounting 10.0.244.196:/ on /var/lib/kubelet/pods/14af0af3-da2e-4276-92e6-eb39d0d57341/volumes/kubernetes.io~nfs/pvc-79743abd-d5c9-4939-a48d-d3038aa30d2a failed: Not supported

What this PR does?:
Enables user to add custom NFS mount options. Applies PR #142 essentially. Credits to author of #142.

Does this PR require any upgrade changes?:
No to my knowledge, maintainers please advise.

If the changes in this PR are manually verified, list down the scenarios covered::
Performed helm template to ensure proper output and tested deployment - worked fine.

Any additional information for your reviewer? :
No.

Checklist:

  • Fixes nfs mount failed Not supported #140
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Does this PR change require updating NFS-Provisioner Chart? If yes, mention the Helm Chart PR #
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them

pentago and others added 2 commits September 19, 2023 05:57
Signed-off-by: pentago <purplertiza@gmail.com>
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc dsharma-dc merged commit 0d2f0c4 into develop Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nfs mount failed Not supported

2 participants