Skip to content

Fix FinalizeLocalVariables crash on Kotlin/Groovy top-level variables #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 2 commits into from
Apr 12, 2026
Merged

Fix FinalizeLocalVariables crash on Kotlin/Groovy top-level variables #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f18f4d
Fix FinalizeLocalVariables crash on Kotlin/Groovy top-level variables…
timtebeek Apr 12, 2026
532b83c
Merge Kotlin/Groovy tests into main FinalizeLocalVariablesTest
timtebeek Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/org/openrewrite/staticanalysis/FinalizeLocalVariables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations m
}

// ignores anonymous class fields, contributed code for issue #181
if (this.getCursorToParentScope(this.getCursor()).getValue() instanceof J.NewClass) {
Object parentScope = this.getCursorToParentScope(this.getCursor()).getValue();
if (parentScope instanceof J.NewClass || parentScope instanceof SourceFile) {
return mv;
}

Expand All @@ -88,7 +89,7 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations m
}

private Cursor getCursorToParentScope(final Cursor cursor) {
return cursor.dropParentUntil(is -> is instanceof J.NewClass || is instanceof J.ClassDeclaration);
return cursor.dropParentUntil(is -> is instanceof J.NewClass || is instanceof J.ClassDeclaration || is instanceof SourceFile);
}
};
}
Expand Down
26 changes: 26 additions & 0 deletions src/test/java/org/openrewrite/staticanalysis/FinalizeLocalVariablesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;

import static org.openrewrite.groovy.Assertions.groovy;
import static org.openrewrite.java.Assertions.java;
import static org.openrewrite.java.Assertions.version;
import static org.openrewrite.kotlin.Assertions.kotlin;

@SuppressWarnings("ALL")
class FinalizeLocalVariablesTest implements RewriteTest {
Expand Down Expand Up @@ -484,6 +486,30 @@ public void doSomething() {
);
}

@Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/702")
@Test
void topLevelKotlinVar() {
rewriteRun(
kotlin(
"""
var x = 1
"""
)
);
}

@Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/702")
@Test
void topLevelGroovyVariable() {
rewriteRun(
groovy(
"""
x = 1
"""
)
);
}

@Test
void initializedInTryCatchFinally() {
rewriteRun(
Expand Down
Loading
⚡