Custom healthcheck with filters

[kavilla]

Description

Enable filtering with custom health checks based on node attributes:

opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}

Also, fixes issue that expects the response to array when it was a
dictionary.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

#2214
#2203

Check List

• New functionality includes testing.
  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

[seraphjiang]

What happen to existing 1.2 customer who forget to update their dashboards.yml file fromopensearch.optimizedHealthcheckId to opensearch.optimizedHealthcheck.Id

[tianleh]

OSD will fail to start because opensearch.optimizedHealthcheckId cannot be recognized. We can call this out in the release note that customers may need to update their yml. It may be a bit over engineering if we want to keep both optimizedHealthcheckId and optimizedHealthcheck and have if/else to use optimizedHealthcheckId if it is provided optimizedHealthcheckId.

[kavilla]

I've added this to the deprecated service so it will work and properly map the value from optimizedHealthcheckId -> optimizedHealthcheck.id and then log a warning message to use the new configuration

[tianleh]

@kavilla I missed the deprecated service part initially. Looks good!

[opensearch-trigger-bot]

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2232-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e6bbb405441c7d59a8d5df6a477c5e432fa88b87
# Push it to GitHub
git push --set-upstream origin backport/backport-2232-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2232-to-1.x.

[opensearch-trigger-bot]

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2232-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e6bbb405441c7d59a8d5df6a477c5e432fa88b87
# Push it to GitHub
git push --set-upstream origin backport/backport-2232-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2232-to-1.3.

[opensearch-trigger-bot]

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport/backport-2232-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e6bbb405441c7d59a8d5df6a477c5e432fa88b87
# Push it to GitHub
git push --set-upstream origin backport/backport-2232-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport/backport-2232-to-1.2.