[D&D] Adds Bar line and Area charts to Wizard by ashwin-pc · Pull Request #2266 · opensearch-project/OpenSearch-Dashboards

ashwin-pc · 2022-09-03T05:01:09Z

Description

Adds Bar line and Area charts to Wizard
Adds resizable right nav to Wizard
E2E tests for bar chart and chart switching

Issues Resolved

Check List

codecov-commenter · 2022-09-03T05:42:14Z

Codecov Report

Merging #2266 (dd6aadd) into main (4a06f5a) will decrease coverage by 0.21%.
The diff coverage is 11.90%.

@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
- Coverage   66.77%   66.55%   -0.22%     
==========================================
  Files        3133     3169      +36     
  Lines       60086    60315     +229     
  Branches     9154     9180      +26     
==========================================
+ Hits        40121    40145      +24     
- Misses      17775    17981     +206     
+ Partials     2190     2189       -1

Impacted Files	Coverage Δ
src/plugins/vis_type_vislib/public/index.ts	`0.00% <ø> (ø)`
src/plugins/visualizations/public/index.ts	`0.00% <ø> (ø)`
src/plugins/wizard/public/application/app.tsx	`33.33% <0.00%> (-16.67%)`	⬇️
...ublic/application/components/experimental_info.tsx	`66.66% <0.00%> (+16.66%)`	⬆️
...wizard/public/application/components/right_nav.tsx	`13.33% <0.00%> (-6.67%)`	⬇️
...wizard/public/application/components/workspace.tsx	`4.00% <0.00%> (-0.17%)`	⬇️
...zard/public/visualizations/metric/to_expression.ts	`6.12% <0.00%> (+0.66%)`	⬆️
...ations/vislib/area/components/area_vis_options.tsx	`0.00% <0.00%> (ø)`
...lib/histogram/components/histogram_vis_options.tsx	`0.00% <0.00%> (ø)`
...ations/vislib/line/components/line_vis_options.tsx	`0.00% <0.00%> (ø)`
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

joshuarrrr

Nice job on getting all the basics working! Some questions and callouts for future work, but I think this will give people a lot more freedom to play with the tool!

Now that we have all the functionality working, we'll want to also set aside some more time to get a lot of the defaults set, which will minimize user steps for common tasks.

Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

AMoo-Miki · 2022-09-07T22:32:12Z

 * SPDX-License-Identifier: Apache-2.0
 */

-import { cloneDeep } from 'lodash';


kavilla

works for me!

* Working histogram Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds histogram options Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds line chart Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds area chart Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * updates nav sizes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * adds resizeable container to right nav Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds chart switcher test Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Github comment feedback Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Updates copy Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 77af7f9)

Description * Adds Bar line and Area charts to Wizard * Adds resizable right nav to Wizard * E2E tests for bar chart and chart switching Issues Resolved: #1616 #1617 #1618 Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

* Working histogram Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds histogram options Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds line chart Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds area chart Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * updates nav sizes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * adds resizeable container to right nav Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds chart switcher test Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Github comment feedback Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Updates copy Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

… (opensearch-project#2291) Description * Adds Bar line and Area charts to Wizard * Adds resizable right nav to Wizard * E2E tests for bar chart and chart switching Issues Resolved: opensearch-project#1616 opensearch-project#1617 opensearch-project#1618 Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

* Working histogram Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds histogram options Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds line chart Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds area chart Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * updates nav sizes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * adds resizeable container to right nav Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds chart switcher test Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Github comment feedback Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Updates copy Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

ashwin-pc requested a review from a team as a code owner September 3, 2022 05:01

ashwin-pc self-assigned this Sep 3, 2022

ashwin-pc added the vis builder label Sep 3, 2022

ashwin-pc added 7 commits September 7, 2022 09:59

Working histogram

8fbd20f

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

Adds histogram options

7841c81

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

Adds line chart

aa3c2ac

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

Adds area chart

f71d630

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

updates nav sizes

b49ba63

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

adds resizeable container to right nav

3b6c3d3

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

Misc fixes

3769a3a

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

ashwin-pc force-pushed the feature/histogram-dnd branch from 9e60bd8 to 3769a3a Compare September 7, 2022 10:16

Adds chart switcher test

240cc1e

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

ashwin-pc added v2.3.0 backport 2.x labels Sep 7, 2022

joshuarrrr previously approved these changes Sep 7, 2022

View reviewed changes

ashwin-pc dismissed joshuarrrr’s stale review via 1fddafc September 7, 2022 19:48

Github comment feedback

e8b4899

Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

ashwin-pc force-pushed the feature/histogram-dnd branch from 1fddafc to e8b4899 Compare September 7, 2022 20:13

Updates copy

dd6aadd

Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>

joshuarrrr approved these changes Sep 7, 2022

View reviewed changes

AMoo-Miki reviewed Sep 7, 2022

View reviewed changes

AMoo-Miki approved these changes Sep 7, 2022

View reviewed changes

bandinib-amzn approved these changes Sep 7, 2022

View reviewed changes

kavilla approved these changes Sep 8, 2022

View reviewed changes

ashwin-pc merged commit 77af7f9 into opensearch-project:main Sep 8, 2022

opensearch-trigger-bot bot mentioned this pull request Sep 8, 2022

[Backport 2.x] [D&D] Adds Bar line and Area charts to Wizard #2291

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[D&D] Adds Bar line and Area charts to Wizard#2266

[D&D] Adds Bar line and Area charts to Wizard#2266
ashwin-pc merged 10 commits intoopensearch-project:mainfrom
ashwin-pc:feature/histogram-dnd

ashwin-pc commented Sep 3, 2022 •

edited

Loading

Uh oh!

codecov-commenter commented Sep 3, 2022 •

edited

Loading

Uh oh!

joshuarrrr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AMoo-Miki Sep 7, 2022 •

edited

Loading

Uh oh!

kavilla left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ashwin-pc commented Sep 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

codecov-commenter commented Sep 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joshuarrrr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AMoo-Miki Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kavilla left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ashwin-pc commented Sep 3, 2022 •

edited

Loading

codecov-commenter commented Sep 3, 2022 •

edited

Loading

AMoo-Miki Sep 7, 2022 •

edited

Loading