[backport 2.x]Replace re2 with RegExp in timeline and add unit tests#4203
Merged
manasvinibs merged 2 commits intoopensearch-project:2.xfrom Jun 15, 2023
Merged
[backport 2.x]Replace re2 with RegExp in timeline and add unit tests#4203manasvinibs merged 2 commits intoopensearch-project:2.xfrom
re2 with RegExp in timeline and add unit tests#4203manasvinibs merged 2 commits intoopensearch-project:2.xfrom
Conversation
Remove re2 usage and replace it with JavaScript built-in RegExp object. Also add more unit tests to make sure that using RegExp has same expressions as using re2 library. Issue Resolve opensearch-project#3901 Backport PR opensearch-project#3908 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
requested review from
AMoo-Miki,
Flyingliuhub,
ZilongX,
abbyhu2000,
ashwin-pc,
joshuarrrr,
kavilla,
kristenTian,
manasvinibs,
seanneumann,
zengyan-amazon and
zhongnansu
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4203 +/- ##
==========================================
+ Coverage 66.37% 66.39% +0.01%
==========================================
Files 3229 3229
Lines 62139 62141 +2
Branches 9626 9627 +1
==========================================
+ Hits 41245 41256 +11
+ Misses 18571 18561 -10
- Partials 2323 2324 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Flyingliuhub
previously approved these changes
Jun 2, 2023
zhongnansu
previously approved these changes
Jun 8, 2023
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
manasvinibs
approved these changes
Jun 14, 2023
abbyhu2000
approved these changes
Jun 15, 2023
ashwin-pc
changed the title
8 tasks
8 tasks
ashwin-pc
changed the title
re2 with RegExp in timeline and add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove re2 usage and replace it with JavaScript built-in RegExp object. Also add more unit tests to make sure that using RegExp has same expressions as using re2 library.
Issue Resolve
#3901
Backport PR
#3908
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr