Remove lmdb-store to fix backport issue#4266
Merged
ananzh merged 1 commit intoopensearch-project:2.xfrom Jun 9, 2023
Merged
Conversation
ananzh
requested review from
AMoo-Miki,
Flyingliuhub,
ZilongX,
abbyhu2000,
ashwin-pc,
joshuarrrr,
kavilla,
kristenTian,
manasvinibs,
seanneumann,
zengyan-amazon and
zhongnansu
as code owners
Issue Resolve opensearch-project#4260 Signed-off-by: ananzh <ananzh@amazon.com>
ananzh
force-pushed
the
2.x-remove-lmdb-store
branch
from
2ebc965 to
986eb8c
Compare
AMoo-Miki
approved these changes
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #4266 +/- ##
==========================================
+ Coverage 66.36% 66.38% +0.01%
==========================================
Files 3229 3229
Lines 62121 62121
Branches 9619 9619
==========================================
+ Hits 41229 41241 +12
+ Misses 18572 18560 -12
Partials 2320 2320
Flags with carried forward coverage won't be shown. Click here to find out more. |
kavilla
approved these changes
Jun 9, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-4266-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34094129a14a6811e509dcaae51d516dd1f8c24b
# Push it to GitHub
git push --set-upstream origin backport/backport-4266-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.8Then, create a pull request where the |
Collaborator
|
Went into 2.x with #4203 and out with 2.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Resolve
#4260
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr