[Fix] Change panel header & update snapshot#5304
Merged
ananzh merged 1 commit intoopensearch-project:mainfrom Oct 17, 2023
Merged
[Fix] Change panel header & update snapshot#5304ananzh merged 1 commit intoopensearch-project:mainfrom
ananzh merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Willie Hung <willie880201044@gmail.com>
willie-hung
requested review from
AMoo-Miki,
BSFishy,
Flyingliuhub,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
curq,
joshuarrrr,
kavilla,
kristenTian,
manasvinibs,
seanneumann,
zengyan-amazon and
zhongnansu
as code owners
Codecov Report
@@ Coverage Diff @@
## main #5304 +/- ##
=======================================
Coverage 66.77% 66.77%
=======================================
Files 3284 3284
Lines 63095 63095
Branches 10049 10049
=======================================
Hits 42134 42134
Misses 18488 18488
Partials 2473 2473
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuarrrr
added
the
Skip-Changelog
joshuarrrr
approved these changes
Oct 16, 2023
Member
joshuarrrr
left a comment
joshuarrrr
left a comment
There was a problem hiding this comment.
LGTM. I think we can skip a changelog entry for this fix.
ananzh
approved these changes
Oct 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
Signed-off-by: Willie Hung <willie880201044@gmail.com> (cherry picked from commit 286cc38) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
pushed a commit
that referenced
this pull request
Oct 26, 2023
Signed-off-by: Willie Hung <willie880201044@gmail.com> (cherry picked from commit 286cc38) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
pushed a commit
that referenced
this pull request
Oct 27, 2023
(cherry picked from commit 286cc38) Signed-off-by: Willie Hung <willie880201044@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
Signed-off-by: Willie Hung <willie880201044@gmail.com> (cherry picked from commit 286cc38) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Feb 9, 2024
(cherry picked from commit 286cc38) Signed-off-by: Willie Hung <willie880201044@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Discover page ("Open" tab), changed the panel header from "Open search" to "OpenSearch".
Issues Resolved
Open search#5145Screenshot
Before
After
Testing the changes
Check List
yarn test:jestyarn test:jest_integration