Skip to content

Search OSM notes by ID#10062

Merged
tyrasd merged 4 commits intoopenstreetmap:developfrom
laigyu:search-OSM-notes-by-ID
Jan 24, 2024
Merged

Search OSM notes by ID#10062
tyrasd merged 4 commits intoopenstreetmap:developfrom
laigyu:search-OSM-notes-by-ID

Conversation

@laigyu
Copy link
Copy Markdown
Contributor

@laigyu laigyu commented Jan 8, 2024

Closes #7618

only support number without prefix,
I wonder if needed to treat note as osmEntity, and support one letter shortcut,
but 'n' is taken by node.

noteSearchId

re: openstreetmap#7618
only support number without prefix
@tyrasd tyrasd added the usability An issue with ease-of-use or design label Jan 17, 2024
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Jan 17, 2024

Thanks 👍 It totally makes sense to be able to search for notes by id as well 👍

support one letter shortcut, but 'n' is taken by node.

Yeah, it's a bit unfortunate that n is clashing. But I'd say we could support note in the id regex in the following line to be able to search for example for note123 or note/123:

var idMatch = !locationMatch && q.match(/(?:^|\W)(node|way|relation|[nwr])\W{0,2}0*([1-9]\d*)(?:\W|$)/i);

@tyrasd tyrasd merged commit 5966863 into openstreetmap:develop Jan 24, 2024
@laigyu laigyu deleted the search-OSM-notes-by-ID branch January 24, 2024 15:11
@laigyu laigyu restored the search-OSM-notes-by-ID branch January 24, 2024 15:11
@laigyu laigyu deleted the search-OSM-notes-by-ID branch April 5, 2024 05:15
bhousel added a commit to facebook/Rapid that referenced this pull request Apr 30, 2024
@k-yle k-yle mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

usability An issue with ease-of-use or design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search OSM notes by ID

2 participants