support 3rd-party icons for preset fields#10254
Closed
k-yle wants to merge 1 commit intoopenstreetmap:developfrom
Closed
support 3rd-party icons for preset fields#10254k-yle wants to merge 1 commit intoopenstreetmap:developfrom
k-yle wants to merge 1 commit intoopenstreetmap:developfrom
Conversation
tyrasd
reviewed
Jun 5, 2024
Member
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
I'm not sure if this is a good idea: "Regular" presets don't use external icons in general. This has the benefit that consumers of the presets can predict which icons might appear. External icons were introduced for NSI because it was deemed unfeasible to maintain an icon set for the large amount of brands in that data set. This is however generally not the case for regular presets from the id-tagging-schema. The icons in the example screenshot could simply be added to temaki, couldn't they?
Collaborator
I agree and added ideditor/schema-builder#161 so we can clarify this in the schema repo at some point. |
matkoniecz
added a commit
to matkoniecz/schema-builder
that referenced
this pull request
Mar 5, 2026
See openstreetmap/iD#10254 Fixes ideditor#161 It is project-specific documentation but makes sense to put it here given how significant user this specific projects are.
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iD already supports third-party icons for presets, but not for fields.
This PR resolves the inconsistency, which is very useful for some presets.