Skip to content

Enable dependabot for GitHub Actions dependencies#11093

Merged
tyrasd merged 2 commits intoopenstreetmap:developfrom
Harvester57:ci-improvements
Jun 4, 2025
Merged

Enable dependabot for GitHub Actions dependencies#11093
tyrasd merged 2 commits intoopenstreetmap:developfrom
Harvester57:ci-improvements

Conversation

@Harvester57
Copy link
Copy Markdown
Contributor

This PR adds the following:

  • Dependabot configuration for GitHub Actions
  • Explicit version pinning for GitHub Actions, to improve Depdendabot alerting

@Harvester57
Copy link
Copy Markdown
Contributor Author

I also played with CodeQL for TypeScript/Javascript, and nodejsscan, as you can see here: develop...Harvester57:iD:develop, but the results (cf. https://github.com/Harvester57/iD/security/code-scanning) are not very convincing, so I left that part out

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jun 4, 2025

Will this create single PRs per dependency or one Issue where all changes are collected (this dashboard like issue).
Personally, I would prefer the dashboard because getting all those irrelevant notification mails is annoying :-).


Something different: Do you know if openstreetmap/id-tagging-schema#1255 makes sense and if we want it here as well?

@tyrasd tyrasd added the chore-dependabot Automated PRs for keeping dependencies up-to-date label Jun 4, 2025
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Jun 4, 2025

Will this create single PRs per dependency

I assume so, but as the github actions only really use a small handfull of dependencies, I don't see a huge influx of new PRs.

If you mean this on a general basis: yes, I see that the dependabot PRs can become a bit spammy at times. We could try something else, if you like. But I'm currently failing to find the configuration option to make it do something else than a PR per dependency upgrade. Am I overlooking something?

Something different: Do you know if openstreetmap/id-tagging-schema#1255 makes sense and if we want it here as well?

Interestingly, in the iD repo, dependabot does already do what you've outlined in the mentioned issue: see e.g. https://github.com/openstreetmap/iD/pull/11085/files
At first glance, I'm not sure what's different in the tagging repo that it behaves differently there… 🤔 But let's investigate this in the other issue, shall we?

@tyrasd tyrasd changed the title Improve GitHub Actions Enable dependabot for GitHub Actions dependencies Jun 4, 2025
@tyrasd tyrasd merged commit 6af6e1b into openstreetmap:develop Jun 4, 2025
3 checks passed
@Harvester57
Copy link
Copy Markdown
Contributor Author

You can group the dependencies PRs into various groups, such as dev and prod environments, or only security-related updates, etc.

The documentation is here: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/optimizing-pr-creation-version-updates

@Harvester57
Copy link
Copy Markdown
Contributor Author

Here is how it looks when grouped: Harvester57#2

I'll try to separate production and dev dependencies in two different groups, then you can have a different scheduling strategy depending on the type (daily for prod, weekly for dev, for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore-dependabot Automated PRs for keeping dependencies up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants